MAST: MastMissions improvements#3588
Open
snbianco wants to merge 2 commits intoastropy:mainfrom
Open
Conversation
Codecov Report❌ Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## main #3588 +/- ##
=======================================
Coverage 73.22% 73.23%
=======================================
Files 226 226
Lines 21000 21010 +10
=======================================
+ Hits 15378 15386 +8
- Misses 5622 5624 +2 ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
Contributor
Author
|
For your awareness: @sedonaprice @bmorris3 @ttdu |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This PR includes some improvements for our
MastMissionsclass:MastMissionsmetadata query functions now include search parameters in the metadata of theastropy.table.Tableobject and column descriptions in the column metadata.pass_idas an alias for the Roman mission'spasscolumn in query functions to avoid conflicts withthe reserved Python keyword.
download_productsso that when a user inputs a JSON file from the subscription service, the value ofmissionis taken from the data. This will allow users to download products from multiple missions in a single call.test_mast.pyfile where a directory was being created outside of the test environment.